Fix ConfigurationValidator incorrectly validating non-existent Commer… #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceConfiguration (#579) * Initial plan * Fix ConfigurationValidator to properly check if CommerceConfiguration exists and add tests Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com> * Fix code formatting to pass dotnet format verification Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: petrinecp <5637849+petrinecp@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in ConfigurationValidator where it incorrectly validated CommerceConfiguration even when it doesn't exist in the configuration, and adds comprehensive test coverage.
Changes:
- Fixed ConfigurationValidator to use
.Exists()instead of null check for CommerceConfiguration section - Added three unit tests covering various CommerceConfiguration scenarios
- Added CLI project reference to test project to enable testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Migration.Tool.CLI/ConfigurationValidator.cs | Fixed bug by changing from null check to .Exists() check for CommerceConfiguration validation |
| Migration.Tool.Tests/ConfigurationValidatorTests.cs | Added comprehensive unit tests for CommerceConfiguration validation scenarios |
| Migration.Tool.Tests/Migration.Tool.Tests.csproj | Added project reference to CLI project to enable access to ConfigurationValidator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pohromj
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ConfigurationValidator to properly check if CommerceConfiguration exists and add tests